lh03061238 added a comment. In D139158#3974801 <https://reviews.llvm.org/D139158#3974801>, @DavidSpickett wrote:
> Looks mechanically fine. These classes are all a bit of a copy paste job > right now, so if you were going to take inspiration riscv is your best bet. > > On the subject of coding style, > https://lldb.llvm.org/resources/contributing.html. > > Coding Style: LLDB’s code style differs from LLVM’s coding style. > Unfortunately there is no document describing the differences. Please be > consistent with the existing code. > > Which isn't super helpful but in general look at something central like > `lldb/source/Target/Process.cpp` and see what it does. The main difference > you'll see is `variable_names_with_underscores_like_this` and `m_` prefix for > class members. > > For me, the style here looks fine. Thanks for your suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139158/new/ https://reviews.llvm.org/D139158 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
