[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

[David Spickett via Phabricator via lldb-commits]

DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7612
+              ->getIntegerType()
+              ->isSpecificBuiltinType(BuiltinType::Bool)) &&
          "only boolean supported");
----------------
aeubanks wrote:
> DavidSpickett wrote:
> > Can you call `TypeSystemClang::IsBooleanType` from here instead?
> better?
Much!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137045/new/

https://reviews.llvm.org/D137045

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits