jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed.
This looks good. The one detail that remains is error handling for the command. You can't provide the --regex option and this matcher at the same time, and it is also an error to have both this matcher function and any arguments in the argument list. We handle the former by judicious use of "option groups" (see the Group(N) entries in the Option.td). The latter you will have to do by hand, checking that if match_type is eFormatterMatchCallback, then if there are any arguments, you should raise an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137000/new/ https://reviews.llvm.org/D137000 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
