DavidSpickett added inline comments.
================ Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:435 + ASSERT_EQ(result.GetValueType(), Value::ValueType::LoadAddress); +} ---------------- DavidSpickett wrote: > There are two `target && target->GetArchitecture().GetCore() == > ArchSpec::eCore_wasm32` checks, does this cover both? > > (will probably be obvious once the diff has context) I think the answer to this is no, you need to add a test for `DW_OP_GNU_addr_index`? Not sure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135664/new/ https://reviews.llvm.org/D135664 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
