tonkosi added a comment. Thanks for the fix Will!
Just one question: cpp test file contains the expression `a[10].c` and the test complains about the expression path `a->c`. If I understand correctly, with the latest fix, that would become `a[10]->c`, which is not the original expression (object access vs pointer access). Was it like that before or did I mess up something else as well? (the test expects only the substring "a[10]" so I guess it's possible it was like that before) ================ Comment at: lldb/source/Core/ValueObject.cpp:1947 - // name ([%d]) to the expression path - if (m_flags.m_is_array_item_for_pointer && - epformat == eGetExpressionPathFormatHonorPointers) ---------------- hawkinsw wrote: > I am *absolutely* not an expert here but I've spent several hours trying to > debug why this incredibly thorough, well-written patch does not handle the > case in `TestArray.py`. It would seem to me that this is the check that we > forgot to bring over in to the new logic. I was attempting to be able to have > an updated version of the patch by tonight, but didn't get further than just > debugging. I will continue to work on it -- I am sure that you gurus have > other, more important things to work on. > > That said, I am just trying to help so if I am totally off base, please let > me know! > > Sincerely, > Will Whoops, nice catch. I somehow deleted this part when refactoring the code and forgot about it. Thanks for looking into this and fixing it, Will :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/new/ https://reviews.llvm.org/D132734 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
