zequanwu added a comment.

In D136209#3866933 <https://reviews.llvm.org/D136209#3866933>, @rnk wrote:

> Right, so `cantFail` must be an assertions-only check. That's not great.

With assertion enabled, lldb still silently deserialize member functions as 
non-member functions. My guess is that `TypeDeserializer::deserializeAs` 
doesn't return error in this case since `sizeof(MemberFunctionRecord)` > 
`sizeof(ProcedureRecord)`. We may need additional checking in 
TypeDeserializer::deserializeAs to verify that we are deserializing the correct 
type.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136209/new/

https://reviews.llvm.org/D136209

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to