aeubanks added inline comments.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1561
+std::string
+DWARFASTParserClang::GetCPlusPlusQualifiedName(const DWARFDIE &die) {
+ if (!die.IsValid())
----------------
dblaikie wrote:
> Sorry, when I gave feedback on some pieces of this that were just moved
> around rather than new code written in this review - I don't mind the code
> moving around without changes (and optionally before/after the move making
> improvements, but not necessary).
>
> If possible, might simplify the code review to move the code first/separately
> from this change, if the move isn't too meaningless independent of the rest
> of the changes?
https://reviews.llvm.org/D135979
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134378/new/
https://reviews.llvm.org/D134378
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
