aeubanks added inline comments.
================ Comment at: lldb/test/API/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.py:16 + + self.expect("image lookup -A -t Foo", DATA_TYPES_DISPLAYED_CORRECTLY, substrs=["2 matches found", "\nid =", "\nid ="]) ---------------- DavidSpickett wrote: > Could you match the whole string here? A bit easier to see at a glance that > way. Unless the output is not stable? it's ``` (lldb) im loo -t Foo 2 matches found in /home/aeubanks/repos/llvm-project/build/cmake/lldb-test-build.noindex/lang/cpp/type_lookup_duplicate/TestCppTypeLookupDuplicate.test_namespace_only_dwarf/a.out: id = {0x0000004f}, name = "Foo", qualified = "a::Foo", byte-size = 1, decl = main.cpp:2, compiler_type = "struct Foo { }" id = {0x00000058}, name = "Foo", qualified = "b::Foo", byte-size = 1, decl = main.cpp:6, compiler_type = "struct Foo { }" ``` I'd rather not depend so much on the exact output since that doesn't necessarily look stable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135827/new/ https://reviews.llvm.org/D135827 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits