This revision was automatically updated to reflect the committed changes. Closed by commit rG021a3d5a3f73: [lldb] Start from end of previous substr when checking ordered substrs (authored by aeubanks).
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135826/new/ https://reviews.llvm.org/D135826 Files: lldb/packages/Python/lldbsuite/test/concurrent_base.py lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py Index: lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py =================================================================== --- lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py +++ lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py @@ -116,7 +116,7 @@ substrs=[ '(char *) $', ' = ptr = ', - ' "1234567890123456789012345678901234567890123456789012345678901234ABC"']) + '"1234567890123456789012345678901234567890123456789012345678901234ABC"']) self.runCmd("type summary add -c TestPoint") Index: lldb/packages/Python/lldbsuite/test/lldbtest.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lldbtest.py +++ lldb/packages/Python/lldbsuite/test/lldbtest.py @@ -2358,7 +2358,7 @@ start = 0 for substr in substrs: index = output[start:].find(substr) - start = start + index if ordered and matching else 0 + start = start + index + len(substr) if ordered and matching else 0 matched = index != -1 log_lines.append("{} sub string: \"{}\" ({})".format( expecting_str, substr, found_str(matched))) Index: lldb/packages/Python/lldbsuite/test/concurrent_base.py =================================================================== --- lldb/packages/Python/lldbsuite/test/concurrent_base.py +++ lldb/packages/Python/lldbsuite/test/concurrent_base.py @@ -74,9 +74,7 @@ bpno = lldbutil.run_break_set_by_file_and_line( self, self.filename, line, num_expected_locations=-1) bp = self.inferior_target.FindBreakpointByID(bpno) - descriptions.append( - ": file = 'main.cpp', line = %d" % - self.finish_breakpoint_line) + descriptions.append(": file = 'main.cpp', line = %d" % line) return bp def inferior_done(self):
Index: lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py =================================================================== --- lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py +++ lldb/test/API/functionalities/data-formatter/data-formatter-cpp/TestDataFormatterCpp.py @@ -116,7 +116,7 @@ substrs=[ '(char *) $', ' = ptr = ', - ' "1234567890123456789012345678901234567890123456789012345678901234ABC"']) + '"1234567890123456789012345678901234567890123456789012345678901234ABC"']) self.runCmd("type summary add -c TestPoint") Index: lldb/packages/Python/lldbsuite/test/lldbtest.py =================================================================== --- lldb/packages/Python/lldbsuite/test/lldbtest.py +++ lldb/packages/Python/lldbsuite/test/lldbtest.py @@ -2358,7 +2358,7 @@ start = 0 for substr in substrs: index = output[start:].find(substr) - start = start + index if ordered and matching else 0 + start = start + index + len(substr) if ordered and matching else 0 matched = index != -1 log_lines.append("{} sub string: \"{}\" ({})".format( expecting_str, substr, found_str(matched))) Index: lldb/packages/Python/lldbsuite/test/concurrent_base.py =================================================================== --- lldb/packages/Python/lldbsuite/test/concurrent_base.py +++ lldb/packages/Python/lldbsuite/test/concurrent_base.py @@ -74,9 +74,7 @@ bpno = lldbutil.run_break_set_by_file_and_line( self, self.filename, line, num_expected_locations=-1) bp = self.inferior_target.FindBreakpointByID(bpno) - descriptions.append( - ": file = 'main.cpp', line = %d" % - self.finish_breakpoint_line) + descriptions.append(": file = 'main.cpp', line = %d" % line) return bp def inferior_done(self):
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits