jingham added a comment.

That seems fine.  I think it's useful to be able to see breakpoint hit counts 
up to the point where you start a new process.  From looking at the code, it 
looks like putting the clear in CleanupProcess will do that.  If you agree this 
is useful, can you add to the test that the hit count is still 1 between 
process.Kill and connecting to the new process?  Other than that this seems 
fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134882/new/

https://reviews.llvm.org/D134882

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to