Author: Dave Lee Date: 2022-10-01T09:58:03-07:00 New Revision: 72a86a9dc4c53010f3b493685d0798bf02bf6ebc
URL: https://github.com/llvm/llvm-project/commit/72a86a9dc4c53010f3b493685d0798bf02bf6ebc DIFF: https://github.com/llvm/llvm-project/commit/72a86a9dc4c53010f3b493685d0798bf02bf6ebc.diff LOG: [lldb] Remove scoped timer from high firing and fast running SymbolFileDWARF::FindFunctions Profiles show that `SymbolFileDWARF::FindFunctions` is both high firing (many thousands of calls) and fast running (35 µs mean). Timers like this are noise and load for profiling systems, and can be removed. rdar://100326595 Differential Revision: https://reviews.llvm.org/D134922 Added: Modified: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp index a9d697480deef..348b0e579869c 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp @@ -2355,8 +2355,6 @@ void SymbolFileDWARF::FindFunctions(const Module::LookupInfo &lookup_info, std::lock_guard<std::recursive_mutex> guard(GetModuleMutex()); ConstString name = lookup_info.GetLookupName(); FunctionNameType name_type_mask = lookup_info.GetNameTypeMask(); - LLDB_SCOPED_TIMERF("SymbolFileDWARF::FindFunctions (name = '%s')", - name.AsCString()); // eFunctionNameTypeAuto should be pre-resolved by a call to // Module::LookupInfo::LookupInfo() _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
