jingham added a comment. LGTM
I didn't see a more appropriate datatype than SmallSet in the llvm collection. I wondered about the same thing Dave asked - should the errors mention that this failed because we checked a negative cache - but I think that would be more confusing than helpful to lldb users. If we wanted to track these decisions it would be more appropriate to log them, but I'm not sure even that is necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134906/new/ https://reviews.llvm.org/D134906 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
