clayborg added inline comments.
================ Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:174-181 + // If we have a core file, we will read the current rendezvous state + // from the core file's memory which will indicate there is nothing + // to do, but we need it to load all of the shared libraries. If we + // don't change this, then "info.state" will be set to eAdd and the + // m_previous.state will be eConsistent and GetAction() will return + // eNoAction when we need it to return eTakeSnapshot. + if (IsCoreFile()) ---------------- labath wrote: > How about we just change `GetAction` to directly return `eTakeSnapshot` in > this case? that is a good idea Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134842/new/ https://reviews.llvm.org/D134842 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
