jasonmolenda added a comment.

This looks good to me, fwiw.  I agree with Pavel about hardcoding the order 
that libraries might appear unless that ordering is essentially considered API. 
 We could get in a situation where different versions of windows report the 
binaries in different order, and it might be confusing for people to understand 
why a bot is failing when their desktop passes etc.  Not a platform I know 
anything about though, don't have a real objection.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134636/new/

https://reviews.llvm.org/D134636

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to