labath accepted this revision. labath added a subscriber: zequanwu. labath added a comment. This revision is now accepted and ready to land.
Looks straight forward enough. Tagging @zequanwu, as he might want to do something similar for PDB. ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:41 #include "llvm/Demangle/Demangle.h" #include "clang/AST/CXXInheritance.h" ---------------- I guess the `clang/AST/Type.h` include should be grouped with the other clang includes. I'd recommend deleting this empty line and letting clang-format sort the includes for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134661/new/ https://reviews.llvm.org/D134661 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
