zequanwu marked an inline comment as done. zequanwu added a comment. In D134509#3811203 <https://reviews.llvm.org/D134509#3811203>, @labath wrote:
> It's not clear to me how much of this patch is pure refactoring, and how much > of it is adding new features. It would have been better to split that out > into two patches. > > I see some layout handling code in `UdtRecordCompleter` constructor, but > that's just two lines of code. Is that it, or should I look elsewhere? That change in `UdtRecordCompleter` is fixing the class layout bit size. I'll put it in a separate patch. Now this patch just does refactoring and hooks PdbAstBuilder to TypeSystem to use class layout in native pdb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134509/new/ https://reviews.llvm.org/D134509 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
