clayborg added a comment.

Our other option is to add more headerdoc to the SBError.h file and deal with 
this API issue by stating that the SBError object must be kept alive long 
enough to copy the error string returned by "const char 
*SBError::GetCString()". I am ok with either, I just think that it is currently 
safer and more consistent with all of our other APIs that return "const char *" 
since they all currently return a ConstString copy that will never go away,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134333/new/

https://reviews.llvm.org/D134333

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to