mgorny added inline comments.
================
Comment at: lldb/unittests/Core/CommunicationTest.cpp:140
+
+ // StopReadThread() can hang, so force an external timeout.
+ std::unique_lock<std::mutex> lock{finished_mutex};
----------------
labath wrote:
> I don't understand what is the purpose of this. Can you elaborate?
Arrr, I've accidentally moved this test from the MainLoop patch while rebasing.
Long story short, `StopReadThread()` could hang there if we don't trigger the
callbacks there.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132577/new/
https://reviews.llvm.org/D132577
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
