aprantl added inline comments.
================ Comment at: lldb/source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:457 + filter_modules.EmplaceBack("libc++abi.1.0.dylib"); + filter_modules.EmplaceBack("libc++abi.1.dylib"); } ---------------- fdeazeve wrote: > aprantl wrote: > > Should these be ordered such that the most likely matches on the most > > modern systems come first? > According to @jasonmolenda, the order is not relevant from a practical point > of view, as breakpoints will be set in _all_ of the above (if they exist). > Unless your intent here is for readers to know which files are more common? I also just realized that the ones you added here are the less common ones. So this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132598/new/ https://reviews.llvm.org/D132598 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits