mstorsjo added a comment.
FYI, this patch added some new compilation warnings:
[4055/7050] Building CXX object
tools/lldb/source/Host/CMakeFiles/lldbHost.dir/windows/MainLoopWindows.cpp.obj
llvm-project/lldb/source/Host/windows/MainLoopWindows.cpp:28:9: warning:
unused variable 'result' [-Wunused-variable]
int result = WSAEventSelect(fd, info.event, FD_READ | FD_ACCEPT |
FD_CLOSE);
^
llvm-project/lldb/source/Host/windows/MainLoopWindows.cpp:38:9: warning:
unused variable 'result' [-Wunused-variable]
int result = WSAEventSelect(fd.first, WSA_INVALID_EVENT, 0);
^
llvm-project/lldb/source/Host/windows/MainLoopWindows.cpp:86:8: warning:
unused variable 'result' [-Wunused-variable]
BOOL result = WSACloseEvent(it->second.event);
^
3 warnings generated.
(They're only used in asserts.) I guess we should add void casts to mark the
variables as used outside of asserts.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131159/new/
https://reviews.llvm.org/D131159
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
