On 19/08/2022 09:48, Michał Górny via lldb-commits wrote:

Author: Michał Górny
Date: 2022-08-19T09:48:13+02:00
New Revision: 58157087b0a4fefeabd4cf6e4ee356d6152fd5a6

URL: 
https://github.com/llvm/llvm-project/commit/58157087b0a4fefeabd4cf6e4ee356d6152fd5a6
DIFF: 
https://github.com/llvm/llvm-project/commit/58157087b0a4fefeabd4cf6e4ee356d6152fd5a6.diff

LOG: [lldb] [test] Skip step packet test on non-amd64

Sponsored by: The FreeBSD Foundation

Added:
Modified:
     lldb/test/API/functionalities/gdb_remote_client/TestContinue.py

Removed:

################################################################################
diff  --git a/lldb/test/API/functionalities/gdb_remote_client/TestContinue.py 
b/lldb/test/API/functionalities/gdb_remote_client/TestContinue.py
index 14147fb5b2bf..9c3fa66608d0 100644
--- a/lldb/test/API/functionalities/gdb_remote_client/TestContinue.py
+++ b/lldb/test/API/functionalities/gdb_remote_client/TestContinue.py
@@ -67,6 +67,9 @@ class MyResponder(self.BaseResponder):
          process = self.connect(target)
          self.assertPacketLogContains(["vCont;C13:p400.401"])
+ # uses 'S13' instead of 's' arm (the pc dance?), testing it on one
+    # arch should be entirely sufficient
Well, it means that people with (increasingly common) arm machines can't test it, but even more than that, I am troubled by the fact that the host architecture leaks into this test case. I think we either have a bug in lldb, or in the way we set up these tests.
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to