JDevlieghere added a comment.

In D131741#3717974 <https://reviews.llvm.org/D131741#3717974>, @jasonmolenda 
wrote:

> We already skip these tests for arm64 & arm64e because of the chained fixups 
> and arm64e fixups before that -- and now we're going to skip them on x86_64 
> if the deployment target is new enough (that's the right way to do it, not 
> the linker version) -- I say we skip them on Darwin outright.  Pre-execution, 
> we can't reliably view global variables, unless we talk with the ld64/dyld 
> folks and see if we can reliably get the file offset out of these fields and 
> work out the file address ourselves.

They're XFAILed rather than skipped on Apple Silicon. We can't XFAIL them 
outright on Intel because the bots are running an older OS/Xcode, but you're 
totally right that we could skip them. I'd still like to get this working 
(although I'm not that motivated) once the linker folks finish upstreaming 
support for chained fixups in llvm. That + the fact that skipped tests bit rot 
much faster made me stick with XFAIL. WDYT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131741/new/

https://reviews.llvm.org/D131741

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to