jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM, I was looking at this method last week and had the same idea -- I started
on a patch similar to this, but hadn't finished yet.
================
Comment at: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:566
// external program to find the symbols, don't run it for them.
- if (!force_lookup && g_dbgshell_command == NULL) {
+ if (!force_lookup && dbgshell_command.empty())
+ return false;
----------------
I had this conditional also test if `LLDB_APPLE_DSYMFORUUID_EXECUTABLE` was
currently set in the environment, which is equivalent to if the DBGShellCommand
was set in the com.apple.DebugSymbol preferences. But as I think through it, I
think it's fine -- code is calling Symbol::DownloadObjectAndSymbolFile() when
it is wiling to do a potentially expensive search for the debug information
almost always - `force==true` is the default, and all of the important ones
we're testing in the testsuite.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131303/new/
https://reviews.llvm.org/D131303
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
