labath added a comment. Ok, I think I like this, but since this is pretty finicky code, could I ask you to split it up into smaller patches? The first could be just the interruption refactor. The second could contain all the `m_notification_packet_queue` and `ReadPacket` stuff (I think this one could come with the a c++ unit test in `unittests/Process/gdb-remote/`. And the last one could be the vCtrlC/vCont;t stuff and whatever is left (?)
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp:138 + // and then drain the notification queue + // TODO: issue vCont;t to ensure that all threads have actually stopped + // (this is not needed for LLGS but for gdbserver) ---------------- Could we just send vCont;t to begin with? (I know this was discussed already, but that was before we switched to the new interruption mechanism) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126614/new/ https://reviews.llvm.org/D126614 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
