[Lldb-commits] [PATCH] D131025: Document why test is disabled on macos ventura

[Adrian Prantl via Phabricator via lldb-commits]

aprantl created this revision.
aprantl added reviewers: JDevlieghere, jasonmolenda.
Herald added a project: All.
aprantl requested review of this revision.

Starting with macOS 13 CoreFoundation pulls in Foundation.

rdar://96224141


https://reviews.llvm.org/D131025

Files:
  lldb/test/API/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py


Index: lldb/test/API/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
===================================================================
--- lldb/test/API/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
+++ lldb/test/API/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
@@ -5,7 +5,8 @@
 
 class TestObjCXXBridgedPO(TestBase):
 
-    @expectedFailureAll(macos_version=[">=", "13.0"]) # rdar://96224141
+    @skipIfDarwinEmbedded
+    @skipIf(macos_version=[">=", "13.0"])
     def test_bridged_type_po(self):
         self.build()
         lldbutil.run_to_source_breakpoint(
@@ -17,3 +18,20 @@
         self.expect('po '+pointer_val,
                     "did not get the Objective-C object description",
                     substrs=['CFNumber', '0x', '42'])
+
+    @skipIfDarwinEmbedded
+    @skipIf(macos_version=["<", "13.0"])
+    def test_bridged_type_po(self):
+        """Starting on macOS 13 CoreFoundation links against Foundation,
+           so we always get the Foundation object description.
+        """
+        self.build()
+        lldbutil.run_to_source_breakpoint(
+            self, 'break here', lldb.SBFileSpec('main.mm'))
+        self.expect('po num',
+                    "did not get the Objective-C object description",
+                    substrs=['42'])
+        pointer_val = str(self.frame().FindVariable('num').GetValue())
+        self.expect('po '+pointer_val,
+                    "did not get the Objective-C object description",
+                    substrs=['42'])



Index: lldb/test/API/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
===================================================================
--- lldb/test/API/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
+++ lldb/test/API/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
@@ -5,7 +5,8 @@
 
 class TestObjCXXBridgedPO(TestBase):
 
-    @expectedFailureAll(macos_version=[">=", "13.0"]) # rdar://96224141
+    @skipIfDarwinEmbedded
+    @skipIf(macos_version=[">=", "13.0"])
     def test_bridged_type_po(self):
         self.build()
         lldbutil.run_to_source_breakpoint(
@@ -17,3 +18,20 @@
         self.expect('po '+pointer_val,
                     "did not get the Objective-C object description",
                     substrs=['CFNumber', '0x', '42'])
+
+    @skipIfDarwinEmbedded
+    @skipIf(macos_version=["<", "13.0"])
+    def test_bridged_type_po(self):
+        """Starting on macOS 13 CoreFoundation links against Foundation,
+           so we always get the Foundation object description.
+        """
+        self.build()
+        lldbutil.run_to_source_breakpoint(
+            self, 'break here', lldb.SBFileSpec('main.mm'))
+        self.expect('po num',
+                    "did not get the Objective-C object description",
+                    substrs=['42'])
+        pointer_val = str(self.frame().FindVariable('num').GetValue())
+        self.expect('po '+pointer_val,
+                    "did not get the Objective-C object description",
+                    substrs=['42'])

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits