zequanwu added a comment.

In D130796#3691227 <https://reviews.llvm.org/D130796#3691227>, @zequanwu wrote:

>> If you find yourself needing to do extra work to work its limitations, we 
>> should fix that algorithm instead.
>
> That makes sense. I'll work on fixing `RangeVectorData`.

After thinking it again, not just `RangeVectorData` need to be written but also 
`RangeVector`, although they are similar. It requires rewrite the whole file 
`RangeMap.h` and all other places uses its APIs.
Can we just use `RangeVectorData` as it is right now and fix it later? So, this 
patch is not blocked. Otherwise, this local variables functionality is not 
almost unusable for NativePDB plugin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130796/new/

https://reviews.llvm.org/D130796

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to