mib marked 5 inline comments as done.
mib added inline comments.
================
Comment at:
lldb/examples/python/scripted_process/crashlog_scripted_process.py:47-48
+ if not self.target.GetExecutable() or not self.target.IsValid():
+ # Return error
return
----------------
JDevlieghere wrote:
> The comment says return error but we're not returning anything. Should this
> raise an exception?
I was thinking of adding a `SBCommandObjectReturn` to every script process init
function so we print errors in lldb instead of raising a python exception. That
way we could propage that into the IDEs.
I'm doing that in a follow-up patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129611/new/
https://reviews.llvm.org/D129611
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
