jj10306 accepted this revision.
jj10306 added a comment.
This revision is now accepted and ready to land.
lgtm, two minor comments
================
Comment at: lldb/source/Plugins/Trace/intel-pt/PerfContextSwitchDecoder.cpp:318
+ should_copy = true;
+ } else if (perf_record.IsErrorRecord()) {
+ should_copy = true;
----------------
why do we want the error record?
================
Comment at:
lldb/source/Plugins/Trace/intel-pt/PerfContextSwitchDecoder.cpp:323-325
+ for (size_t i = 0; i < perf_record.size; i++) {
+ out_data.push_back(data[offset + i]);
+ }
----------------
consider using `std::copy` or `.insert` here instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129239/new/
https://reviews.llvm.org/D129239
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
