mgorny marked 2 inline comments as done. mgorny added inline comments.
================ Comment at: lldb/test/API/tools/lldb-server/vCont-threads/main.cpp:18 +std::atomic<bool> can_work = ATOMIC_VAR_INIT(false); +thread_local bool can_exit_now = false; ---------------- labath wrote: > mgorny wrote: > > labath wrote: > > > I guess this should technically be a `volatile sig_atomic_t` > > But with `thread_local`, correct? > Yes. If that's not enough qualifiers, you can even throw in `static`, for > good measure. :) Better overqualified than underqualified! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129012/new/ https://reviews.llvm.org/D129012 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
