labath added inline comments.
================ Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:91 + + def test_unique_base_addresses(self): + # In the past on Windows we were recording AllocationBase as the base address ---------------- rename to test_region_overlap or something along those lines? ================ Comment at: lldb/test/API/functionalities/memory-region/TestMemoryRegion.py:119 + or (region_end > previous_base and region_end <= previous_end): + self.assertFalse(base_address in base_addresses, + "Unexpected overlapping memory region found.") ---------------- I don't see `base_addresses` defined anywhere. I guess this should just be `assertFalse`, and the overlap condition right? Btw, can [[ https://stackoverflow.com/questions/3269434/whats-the-most-efficient-way-to-test-if-two-ranges-overlap | check for overlap ]] with `region_base < previous_end && previous_base < region_end`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129272/new/ https://reviews.llvm.org/D129272 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
