mgorny added inline comments.
================ Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteForkNonStop.py:116 + parent_pid, parent_tid, child_pid, child_tid = ( + self.start_fork_test(["fork", "sleep:2", "print-pid", "sleep:2", + "stop"], ---------------- mgorny wrote: > labath wrote: > > mgorny wrote: > > > mgorny wrote: > > > > I really dislike these sleeps but I can't think of a better way of > > > > doing it (short of using IPC for synchronization). The goal is to 1) > > > > ensure that both processes start before they start outputting, and 2) > > > > ensure that both output before the first stop reason comes. > > > Ok, semaphores are not scary after all, and I suppose we can expect them > > > to work if we expect `fork()` to work. > > > ensure that both processes start before they start outputting > > But we should be able to see the output from the first process (if it had > > any) even it is the only process running. Do we have a test for that? Could > > you add a step where the first process outputs something before it waits to > > synchronize with the second process? > Yes, I suppose covering that with a test also makes sense. Actually, this is already covered by `TestNonStop.py::test_stdio`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128932/new/ https://reviews.llvm.org/D128932 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
