labath added a subscriber: jasonmolenda.
labath added a comment.

In D128541#3622433 <https://reviews.llvm.org/D128541#3622433>, @alvinhochun 
wrote:

> In D128541#3621364 <https://reviews.llvm.org/D128541#3621364>, @labath wrote:
>
>> Well.. most OSes don't have this kind of functionality, so we don't really 
>> have an exact match for this. I suppose the closest thing would be the way 
>> we handle darwin OS logs, so you could try to see if reusing some of that 
>> infrastructure makes sense (StructuredDataDarwinLog.cpp and surrounding 
>> code).
>
> Thanks, `StructuredData` looks interesting and it seems like a nice way to do 
> this (albeit looking to be slightly overcomplicated). But I did a bit of 
> digging and found D106324 <https://reviews.llvm.org/D106324>, and I get the 
> impression that it was planned to be removed eventually. Is it still a good 
> idea to reference that?

Hmm... good question. I don't know. Maybe @jasonmolenda can say something about 
that.

I, for one, would be definitely happy to see that entire subsystem go up in 
smoke, but if there is a use for it, I suppose we can keep it. The fact that 
there is no current user of it means that you may be able to redesign/replace 
the system with something more suitable to your use case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128541/new/

https://reviews.llvm.org/D128541

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to