labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D128638#3611932 <https://reviews.llvm.org/D128638#3611932>, @mgorny wrote:

> BTW this test is getting a bit long as well but I don't have a good idea how 
> to split it, except for just moving some functions into a second file and 
> making some reusable base class.

I don't know if that's necessary right now, but the general approach seems fine 
to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128638/new/

https://reviews.llvm.org/D128638

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to