mstorsjo added a comment. There's consistent typos about the test name in the commit subject and description.
================ Comment at: lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test:1 +REQUIRES: system-windows, lld, (target-arm || target-aarch64) +RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp ---------------- Hmm, I wasn't aware of the fact that you can do such `||` expressions in the `REQUIRES` line - I presume you've verified that this test actually does get picked up and executed? ================ Comment at: lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test:2 +REQUIRES: system-windows, lld, (target-arm || target-aarch64) +RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cpp +RUN: lldb-test symbols -dump-ast %t.exe | FileCheck %s ---------------- Here, there's probably no need to force it to 32 bit mode - unless we expect to have a similar test for the undecorated mangling in aarch64 and x86_64 mode too? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128678/new/ https://reviews.llvm.org/D128678 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
