mstorsjo accepted this revision. mstorsjo added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2 REQUIRES: system-windows, msvc RUN: %build --compiler=clang-cl --mode=compile --arch=32 --nodefaultlib --output=%T/PointerTypeTest.cpp.obj %S/Inputs/PointerTypeTest.cpp RUN: %build --compiler=msvc --mode=link --arch=32 --nodefaultlib --output=%T/PointerTypeTest.cpp.exe %T/PointerTypeTest.cpp.obj ---------------- omjavaid wrote: > mstorsjo wrote: > > I wonder if it'd be better to hardcode this to build for `i386` (assuming > > the `%build` script allows that?) to keep it testing what it was originally > > made to test? > Given we expect this to pass for Windows/Arm it will reduce coverage if made > to run only for x86. Right, as we probably need to link, that would require more of the host environment than we normally require (for other tests where we don't link things, we can compile things for x86 even if we're running on arm, as long as the x86 support is available in the compiler). Given the structure of the lldb tests I guess this is more in line with how things normally are done here, so I guess this is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128668/new/ https://reviews.llvm.org/D128668 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
