jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land.
lgtm - thanks for doing this renaming 🙂 ================ Comment at: lldb/include/lldb/Core/PluginManager.h:346 - static TraceCreateInstanceForSessionFile + static TraceCreateInstanceForBundle GetTraceCreateCallback(llvm::StringRef plugin_name); ---------------- nit: `FromBundle` makes more sense than `ForBundle` imo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128484/new/ https://reviews.llvm.org/D128484 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
