JDevlieghere created this revision.
JDevlieghere added a reviewer: aprantl.
Herald added a project: All.
JDevlieghere requested review of this revision.
Fix an off-by-one error in the utility function used to extract the dynamic
class info. This resulted in a buffer overflow in the inferior which
interrupted our utility function.
https://reviews.llvm.org/D128377
Files:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
Index:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
===================================================================
---
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -199,7 +199,7 @@
DEBUG_PRINTF ("count = %u\n", count);
uint32_t idx = 0;
- for (uint32_t i=0; i<=count; ++i)
+ for (uint32_t i=0; i<count; ++i)
{
if (idx < max_class_infos)
{
@@ -273,7 +273,7 @@
DEBUG_PRINTF ("count = %u\n", count);
uint32_t idx = 0;
- for (uint32_t i=0; i<=count; ++i)
+ for (uint32_t i=0; i<count; ++i)
{
if (idx < max_class_infos)
{
Index: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
===================================================================
--- lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
+++ lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
@@ -199,7 +199,7 @@
DEBUG_PRINTF ("count = %u\n", count);
uint32_t idx = 0;
- for (uint32_t i=0; i<=count; ++i)
+ for (uint32_t i=0; i<count; ++i)
{
if (idx < max_class_infos)
{
@@ -273,7 +273,7 @@
DEBUG_PRINTF ("count = %u\n", count);
uint32_t idx = 0;
- for (uint32_t i=0; i<=count; ++i)
+ for (uint32_t i=0; i<count; ++i)
{
if (idx < max_class_infos)
{
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
