cassanova added inline comments.
================
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:3
+ Support
+ ObjectYAML
+ )
----------------
JDevlieghere wrote:
> I assume we don't need this anymore if we're using the dummy target?
Yes this isn't necessary anymore, I'll remove it and update the revision.
================
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/CMakeLists.txt:21
+ COMMENT "Running the LLDB command interpreter fuzzer..."
+ COMMAND cd ${CMAKE_CURRENT_SOURCE_DIR} &&
$<TARGET_FILE:lldb-commandinterpreter-fuzzer> -dict=inputdictionary.txt
-only_ascii=1
+ USES_TERMINAL
----------------
JDevlieghere wrote:
> Shouldn't we use an absolute path for the input dictionary? Something like
> `${CMAKE_CURRENT_SOURCE_DIR}/inputdictionary.txt`
Yes an absolute path is better here, I'll add it and update the revision.
================
Comment at:
lldb/tools/lldb-fuzzer/lldb-commandinterpreter-fuzzer/lldb-commandinterpreter-fuzzer.cpp:44
+ if (thisinterpreter.IsValid()) {
+ thisinterpreter.HandleCommand("breakpoint set --name main", ro, false);
+ thisinterpreter.HandleCommand(str.c_str(), ro, false);
----------------
JDevlieghere wrote:
> Why do we need a breakpoint?
This was a leftover from when I ran this fuzzer with a non-dummy target,
removing it doesn't seem to affect the fuzzer so I can take this line out and
update the diff.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D128292/new/
https://reviews.llvm.org/D128292
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
