mgorny added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:697
+static int GetSignalForStopReason(const struct ThreadStopInfo &tid_stop_info) {
+ if (tid_stop_info.reason == eStopReasonException)
----------------
labath wrote:
> It seems this struct is only used in the lldb-server. Maybe we could make
> this a member function instead? Or move the signo field out of the union?
I would lean towards the latter, I guess. Lemme look about updating the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127193/new/
https://reviews.llvm.org/D127193
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
