jingham marked an inline comment as done.
jingham added a comment.
In D126513#3550588 <https://reviews.llvm.org/D126513#3550588>, @kastiglione
wrote:
> I noticed that the example python command and this feature don't support
> specifying breakpoint locations. Should it?
Man, that was WAY harder...
================
Comment at: lldb/source/Commands/CommandObjectProcess.cpp:668
+ [this, old_sync]() {
+ this->GetDebugger().SetAsyncExecution(!old_sync);
+ });
----------------
kastiglione wrote:
> this should be `old_sync` (no `!`)
Yup. The scope exit was overkill anyway. I fixed this and also added to the
test to make sure it gets set back correctly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126513/new/
https://reviews.llvm.org/D126513
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
