aheejin added inline comments.
================ Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 - // If the section type is CUSTOM, it has a name already. If it's a new type - // of section that we don't explicitly handle here, it will have an empty - // name and objcopy won't be able to select it by name (e.g. for removal - // or dumping) but it will still be valid and able to be copied. ---------------- dschuff wrote: > aheejin wrote: > > Why was this removed? It doesn't look like it's related to the last section > > thing.. It's just explaning custom sections have names already. > Checking against `WASM_SEC_LAST_KNOWN` ensures that there can't be a new type > of section that we don't explicitly handle here (because no types of known > sections are explicitly handled or mentioned); any section known to > `sectionTypeToString` will work. I'm not sure if I understand. Is this related to `WASM_SEC_TAG` -> `WASM_LAST_SEC_KNOWN` change in this PR? Or it's just an unrelated drive-by fix? > Checking against `WASM_SEC_LAST_KNOWN` ensures that there can't be a new type > of section that we don't explicitly handle here (because no types of known > sections are explicitly handled or mentioned); I'm not sure what this means.. > If the section type is CUSTOM, it has a name already. Why is this deleted too? How is the custom section related to `WASM_SEC_LAST_KNOWN`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127164/new/ https://reviews.llvm.org/D127164 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
