RamNalamothu added a subscriber: labath.
RamNalamothu added a comment.
@jingham @labath
I have tried to add a test but it's becoming difficult for me to come-up with a
failing test scenario. Is it okay to commit this without a test?
Otherwise, I could add the following or error capturing
diff --git a/lldb/source/Commands/CommandObjectThread.cpp
b/lldb/source/Commands/CommandObjectThread.cpp
index 95a8301a318a..f91188f4446b 100644
--- a/lldb/source/Commands/CommandObjectThread.cpp
+++ b/lldb/source/Commands/CommandObjectThread.cpp
@@ -1096,7 +1096,7 @@ protected:
return false;
}
- process->GetThreadList().SetSelectedThreadByID(m_options.m_thread_idx);
+
assert(process->GetThreadList().SetSelectedThreadByID(m_options.m_thread_idx));
StreamString stream;
Status error;
which will break `thread until` functionality and then I can add the patch
fixing it immediately.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D48865/new/
https://reviews.llvm.org/D48865
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
