hawkinsw added a comment. In D126109#3535931 <https://reviews.llvm.org/D126109#3535931>, @JDevlieghere wrote:
> In D126109#3534522 <https://reviews.llvm.org/D126109#3534522>, @hawkinsw > wrote: > >> @DavidSpickett Thanks (again) for the feedback. Once I fix the nit, is the >> proper protocol for you to review again? I am sorry to ask but I don't know >> the right procedure and don't want to do the wrong thing! > > If the patch is accepted with a comment you can land the patch with the > comment addressed. Unless you disagree in which case you can continue > discussing in the code review. Thanks @JDevlieghere ! I have updated the patch according to his feedback and I am running a full test on my desktop. I think that this is ready to land but I still haven't gotten myself in order and requested committer access so I will need your help again. Thanks again for your patience and help getting me acclimated! Contributing is lots of fun! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126109/new/ https://reviews.llvm.org/D126109 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
