[Lldb-commits] [PATCH] D126435: NFC delay tilde expansion on source path remappings until we are opening a source file

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added a comment.

Very nice



================
Comment at: lldb/source/Core/SourceManager.cpp:69-73
+  FileSpec resolved_fspec = file_spec;
+  if (!FileSystem::Instance().Exists(file_spec) &&
+      file_spec.GetDirectory().GetCString()[0] == '~') {
+    FileSystem::Instance().Resolve(resolved_fspec);
+  }
----------------
I would create a little helper function (`resolve_tilde(FileSpec& s)` or 
something) to avoid duplicating this code on line 541?


================
Comment at: lldb/source/Core/SourceManager.cpp:403
                            : DebuggerSP()) {
+//  m_mod_time = FileSystem::Instance().GetModificationTime(m_file_spec);
   CommonInitializer(file_spec, target);
----------------
I guess this shouldn't be here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126435/new/

https://reviews.llvm.org/D126435

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits