JDevlieghere added inline comments.
================
Comment at: lldb/examples/python/crashlog.py:118-119
- # Any frame above frame zero and we have to subtract one to
- # get the previous line entry.
+ # We should substract 1 to every frame's pc above frame zero
+ # to get the previous line entry.
pc = frame.pc & crash_log.addr_mask
----------------
Maybe
> Except for the zeroth frame, we should subtract 1 from every frame pc in
> order to get to the previous line entry
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125928/new/
https://reviews.llvm.org/D125928
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
