mib closed this revision.
mib marked an inline comment as done.
mib added a comment.

Landed in a6926d576131c9ad849fef6f1d43134caab5025e 
<https://reviews.llvm.org/rGa6926d576131c9ad849fef6f1d43134caab5025e>



================
Comment at: lldb/include/lldb/API/SBCompileUnit.h:37
 
+  uint32_t GetIndexForLineEntry(lldb::SBLineEntry &line_entry,
+                                bool exact = false) const;
----------------
JDevlieghere wrote:
> How's this different from `FindLineEntryIndex`? In other words why not make 
> this an `FindLineEntryIndex` overload? It would be good to document this here 
> (too). 
We already have a line entry but we just want to get the index in the compile 
unit, so it made sense to have a separate method for this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125437/new/

https://reviews.llvm.org/D125437

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to