[Lldb-commits] [PATCH] D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

[walter erquinigo via Phabricator via lldb-commits]

wallace added inline comments.


================
Comment at: 
lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp:66
     OptionParsingStarting(ExecutionContext *execution_context) {
-  m_thread_buffer_size = kDefaultThreadBufferSize;
+  m_trace_buffer_size = kDefaultTraceBufferSize;
   m_enable_tsc = kDefaultEnableTscValue;
----------------
jj10306 wrote:
> So now m_trace_buffer_size is the size of each trace buffer, regardless of 
> the buffer is for a single thread or a single core?
yep


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124640/new/

https://reviews.llvm.org/D124640

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits