wallace added inline comments.
================
Comment at: lldb/unittests/Process/Linux/PerfTests.cpp:53
+TEST(Perf, HardcodedLogicalCoreIDs) {
+ Expected<std::vector<int>> core_ids =
----------------
jj10306 wrote:
> Not directly related to this diff, but I just realized the proc fs parsing
> logic doesn't belong in the Perf files since it has nothing to do with perf.
> Feel free to move those functions and these associated tests to a more
> appropriate location or we can do it in a future diff since this isn't the
> diff that made that mistake.
that's a valid point. I'll create a new file
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124573/new/
https://reviews.llvm.org/D124573
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
