siggi-alpheus added a comment.
Thanks for taking a look. Let me see about fixing the test failures and writing
that test.
================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2672
// Handle static members
- if (attrs.is_external && attrs.member_byte_offset == UINT32_MAX) {
+ if (attrs.member_byte_offset == UINT32_MAX) {
Type *var_type = die.ResolveTypeUID(attrs.encoding_form.Reference());
----------------
labath wrote:
> Have you run the test suite? I'd guess that you'd need to check for
> DW_AT_data_bit_offset here as well.
Yeah, I ran the tests overnight and I see a couple of tests failing. Will see
about fixing and writing a test for the case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124409/new/
https://reviews.llvm.org/D124409
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
