omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land.
LGTM. With a minor nit fix about FixAnyAddress vs FixDataAddress if required. ================ Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:288 + if (lldb::ABISP abi_sp = GetABI()) + addr = abi_sp->FixDataAddress(addr); + ---------------- Is this a candidate for FixAnyAddress ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122411/new/ https://reviews.llvm.org/D122411 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits